Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change by plaisthos. ( 
http://gerrit.openvpn.net/c/openvpn/+/1722?usp=email )

Change subject: Move incoming data processing in its own method
......................................................................


Patch Set 2:

(2 comments)

File src/openvpn/multi.c:

http://gerrit.openvpn.net/c/openvpn/+/1722/comment/521a732d_f2918b0e?usp=email :
PS2, Line 3339: multi_process_incoming_link_data(struct multi_context *m, bool 
floated, struct link_socket *sock)
> should have documentation
Done


http://gerrit.openvpn.net/c/openvpn/+/1722/comment/46dfeace_252523b2?usp=email :
PS2, Line 3346:     lsi = &sock->info;
> any reason not to combine that with the declaration above?
blindness when moving the code around.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1722?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9f10d91407347faf32397535c95e2d80a1575bd5
Gerrit-Change-Number: 1722
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Thu, 25 Jun 2026 13:14:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to