This needs a bit of explanation - on a 64 bit platform, this changes
exactly nothing. On 32 bit platforms (which we still support and test)
this ensures that the file names follow the same format and have the
same amount of randomness as on 64 bit platforms. This in itself
is an "improvement", not a "bugfix" - but there is a CVE bugfix coming,
which brings a unit test with it that verifies "will generated file
names be what we expect here?" - and that test fails on 32 bit
platforms, because, different filenames.
One could have adjusted the unit test ("#ifdef 32BIT"), but we decided
to go for "consistent file names across all platforms" - and since the
bugfix has to go back to 2.5 :-( this one also goes back all the way.
Tested on the offending 32 bit platform (NetBSD) with the offending
unit test, and BB + GHA tested all the rest.
Your patch has been applied to the master, release/2.7, release/2.6
and release/2.5 branch.
commit 712f3d61488a47e80577112489e9e9f98a32aac6 (master)
commit 4558e23156b67ccad389b0594b8d7097c03db999 (release/2.7)
commit bab5ee23e06a5ae1c266ddcd74f8ac09b91eed17 (release/2.6)
commit 8d590a16da67b26971109471ed1aa8afcbfc71c1 (release/2.5)
Author: Arne Schwabe
Date: Fri Jun 26 17:29:46 2026 +0200
Make get_random return int64 instead of long
Signed-off-by: Arne Schwabe <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1732
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg37322.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
