Attention is currently required from: d12fk, plaisthos. stipa has posted comments on this change by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1730?usp=email )
Change subject: openvpnserv: rework ConvertItfDnsDomains and tests ...................................................................... Patch Set 5: Code-Review+2 (2 comments) Patchset: PS5: LGTM except unneeded (anymore) malloc.h, maybe Gert could remove it on commit? File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/1730/comment/b0f3ec4d_3289bc90?usp=email : PS5, Line 36: #include <malloc.h> I don't think this is needed, since malloc is in stdlib.h. Apparently it was been added for _malloca/_freea which we don't use anymore. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1730?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8c67633ed3d82a6dc50fbd8fa1af2c50fc45d938 Gerrit-Change-Number: 1730 Gerrit-PatchSet: 5 Gerrit-Owner: d12fk <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: stipa <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: d12fk <[email protected]> Gerrit-Comment-Date: Sat, 27 Jun 2026 10:07:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
