I have only lightly stared at the code, but Lev has thoroughly reviewed
and tested it - and the unit tests have been significantly extended, so
this function should hopefully now be fixed for good, finally.
It was tested via GH Actions which do build and run the unit tests on
windows.
I have extended the commit message a bit to add the Reported-By: line
of the original reporter, plus references to the private GH repo where
the discussion started - not that useful for non-project members, but if
we want to go back in a few years to see "what triggered this patch?"
it might be useful for us.
Lev requested removal of <malloc.h> as it's not needed for this patch
(there are many more malloc() calls already), but Heiko argues that MSDN
"requires both" - so I consider this a bit of future-proofing.
Your patch has been applied to the master and release/2.7 branch.
Release/2.6 and older do not have the "new DNS NRPT magic" code.
commit 294d5ebb32e632c756290cb7b1de3df29a516154 (master)
commit 59113da80f47d61d7064b1d3b2611b052e4f0923 (release/2.7)
Author: Heiko Hund
Date: Sun Jun 28 15:02:50 2026 +0200
openvpnserv: rework ConvertItfDnsDomains and tests
Signed-off-by: Heiko Hund <[email protected]>
Acked-by: Lev Stipakov <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1730
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg37337.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
