Attention is currently required from: cron2, plaisthos. stipa has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1736?usp=email )
Change subject: win32: fix plugin trusted-dir check prefix bypass ...................................................................... Patch Set 2: (2 comments) File src/openvpn/win32-util.c: http://gerrit.openvpn.net/c/openvpn/+/1736/comment/eceaf529_9076a5c9?usp=email : PS1, Line 182: if (dir_len == 0 || wcsnicmp(dir, path, dir_len) != 0) > I think since you are doing dir_len -1 below you should maybe change the > dir_len check to be <= 1 dir <= 1 should not happen - we pass normalized dir - but I can fix it anyway. File tests/unit_tests/openvpn/test_misc.c: http://gerrit.openvpn.net/c/openvpn/+/1736/comment/3b37e912_e2c5249b?usp=email : PS1, Line 492: > this upsets clang-format, alas - if you move towards an empty opening brace > (`... […] will fix. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1736?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib7f9c9ce5ed778190445cc4cfaa8f3cd5d1110bc Gerrit-Change-Number: 1736 Gerrit-PatchSet: 2 Gerrit-Owner: stipa <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: cron2 <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Comment-Date: Mon, 29 Jun 2026 12:27:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos <[email protected]> Comment-In-Reply-To: cron2 <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
