Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1726?usp=email )
Change subject: Split multi_get_create_instance_udp into data and control parts ...................................................................... Patch Set 5: Code-Review+2 (1 comment) File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/1726/comment/a9148345_aeae6f6c?usp=email : PS5, Line 295: if (mroute_extract_openvpn_sockaddr(&real, &m->top.c2.from.dest, true) && m->top.c2.buf.len > 0) This looks weird since it repeats `mroute_extract_openvpn_sockaddr` that was already done in the caller. But it will make sense in #1727. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1726?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8e9923b51b77f184c7d49d697004cb02d2b5cfc3 Gerrit-Change-Number: 1726 Gerrit-PatchSet: 5 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Fri, 17 Jul 2026 14:17:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
