Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/31?usp=email )
Change subject: Allow to use OpenSSL's SIPHASH implementation when available ...................................................................... Patch Set 17: Code-Review-2 (3 comments) File src/openvpn/siphash_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/31/comment/82eb4c8f_745f931e?usp=email : PS17, Line 27: #include "config-msvc.h" This shows how old this patch is: config-msvc is gone for years, please remove the reference. http://gerrit.openvpn.net/c/openvpn/+/31/comment/c865d631_0d7e7379?usp=email : PS17, Line 32: #include "siphash.h" these includes could move below the enable check File tests/unit_tests/openvpn/test_crypto.c: http://gerrit.openvpn.net/c/openvpn/+/31/comment/507c0a42_1dbfd977?usp=email : PS17, Line 960: cmocka_unit_test_prestate_setup_teardown(crypto_test_epoch_edge, Removes this test. Conflict resolution error? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/31?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I09aa27caa1a3aab0d1be6118b26d54a1c1bf7aa0 Gerrit-Change-Number: 31 Gerrit-PatchSet: 17 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Fri, 17 Jul 2026 14:56:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
