Attention is currently required from: ordex, plaisthos. ralf_lici has posted comments on this change by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1795?usp=email )
Change subject: dco: make key state desync recoverable ...................................................................... Patch Set 3: (1 comment) File src/openvpn/dco.c: http://gerrit.openvpn.net/c/openvpn/+/1795/comment/81cb31b8_dca9a8fc?usp=email : PS2, Line 203: ASSERT(secondary->dco_status == DCO_INSTALLED_PRIMARY); > should we also convert this ASSERT() since it's basically part of the same > class of problems? Simila […] Yes I agree. I converted this one too, and moved the check before `dco_swap_keys()` so we fail before mutating the kernel key slots if the userspace DCO state is already inconsistent. (also wrapped the printed strings while I was at it) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1795?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4d0887839b4a13a92e92250d1b315dec949698f3 Gerrit-Change-Number: 1795 Gerrit-PatchSet: 3 Gerrit-Owner: ralf_lici <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: ordex <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: ordex <[email protected]> Gerrit-Comment-Date: Tue, 21 Jul 2026 15:31:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ordex <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
