Attention is currently required from: plaisthos. cron2 has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1800?usp=email )
Change subject: Allow extracing other integers from peer info and add a unit test for it ...................................................................... Patch Set 3: Code-Review-1 (4 comments) Patchset: PS3: The overall change from 'field=' to 'field' will create code differences which are going to bite us later when backporting master -> 2.7, so I'm not convinced this is a positive change (always passing in the '=' would actually simplify the `extract_var_peer_info()` a bit, as the first `snprintf()` is no longer needed at all). So maybe not? Besides this there are a few more things that look like they need more love... File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/1800/comment/0c3efa0a_6ee11934?usp=email : PS3, Line 913: ) your 'add ssl_util.c' key seems to be hickuping ;-) File src/openvpn/ssl_util.c: http://gerrit.openvpn.net/c/openvpn/+/1800/comment/05088baa_5ebd86ea?usp=email : PS3, Line 97: if (r == 1 && proto > 0) this looks like a highly complicated way to do `r = sscanf(optstr+strlen(field), "=%d", &proto)` no? http://gerrit.openvpn.net/c/openvpn/+/1800/comment/ace55878_891009fa?usp=email : PS3, Line 116: } why not use `peer_info_extract_uint()` with `MAX_PEER_ID` as "default if unset" value? done, reduced to 1 line -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1800?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iad94e7a9d0b3be8a8db09e9a20eaac6041470ab6 Gerrit-Change-Number: 1800 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Wed, 22 Jul 2026 15:38:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
