Attention is currently required from: cron2, flichtenheld, its_Giaan, ordex.
plaisthos has posted comments on this change by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1089?usp=email ) Change subject: multipeer: introduce asymmetric peer-id ...................................................................... Patch Set 29: Code-Review+2 (2 comments) File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/1089/comment/9dd0589c_911979bb?usp=email : PS29, Line 2333: c->options.use_peer_id = c->c2.tls_multi->use_peer_id; I will accept this for now but I think we should eventually clean that up so we have only one boolean that is the single source of truth instead of having to have two bools that are kept in sync. File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/1089/comment/1e3199ef_e1c248d4?usp=email : PS29, Line 2323: /* Peer has no support for asymmetric peer-id, and DCO currently This sounds like both conditions are true here to me. Can we change tit something that makes it clear that is either condition? ```suggestion /* Peer has either no support for asymmetric peer-id, or DCO is in use and * can only handle symmetric peer IDs */ ``` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1089?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0a13ee90b6706acf20eabcee3bab3f2dff639bf9 Gerrit-Change-Number: 1089 Gerrit-PatchSet: 29 Gerrit-Owner: its_Giaan <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: ordex <[email protected]> Gerrit-Attention: its_Giaan <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: ordex <[email protected]> Gerrit-Comment-Date: Tue, 28 Jul 2026 12:08:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
