Attention is currently required from: flichtenheld. plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1727?usp=email )
Change subject: Add lookup of multi session by session id ...................................................................... Patch Set 26: (4 comments) File src/openvpn/multi.h: http://gerrit.openvpn.net/c/openvpn/+/1727/comment/d55f5112_31eb2707?usp=email : PS26, Line 138: /** If this is multi_instance is hashed in the sid lookup table the session > Remove the first "is" and the second "session id" Done File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/1727/comment/de3e6230_c5a2a5a0?usp=email : PS26, Line 431: && dco_enabled(&mi->context.options)) > is this an intended change or a debugging left-over? I think that is a leftover of some of the many assym peer id back and forth that accidentially ended up in this patch. I remove that change. File src/openvpn/sid_hash.h: http://gerrit.openvpn.net/c/openvpn/+/1727/comment/32b92473_dd418a1a?usp=email : PS26, Line 23: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > old header Done http://gerrit.openvpn.net/c/openvpn/+/1727/comment/a7038ae0_64e00167?usp=email : PS26, Line 61: struct hash_element *he_sid = hash_lookup_fast(m->sid_hash, sid_bucket, sid, sid_hv); > should use `multi_hash_sid_lookup()` It looks like that but that does not actually work. The function hash_remove_fast later the function requires sid_bucket and multi_hash_sid_lookup does not actually return that. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1727?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Idb59ecd119331b198792ad1379bec8600211651b Gerrit-Change-Number: 1727 Gerrit-PatchSet: 26 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Sat, 08 Aug 2026 21:53:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
