Good find :-) - going back to the 2.6 source, this is "sort of obviously
correct" (2.6 checked for ce.proto == TCP_SERVER, which does no longer
make sense with the multisocket patch in 2.7 - which got it right for a
"p2mp --server" with a TCP socket, but the "p2p --tcp-server" case got
lost)
For a normal client or server setup this does not change anything, just
for "p2p --tcp-server". The t_server tests test that, as did MaxF's
test setup which led to GH issue 1089. And indeed, maybe I should
setup a "p2p --tcp-server --tls-crypt-v2" instance... :-)
Your patch has been applied to the master and release/2.7 branch (bugfix).
commit 603aa9698c140d15b7464af8fb83bd2aa71da680 (master)
commit c26995bf68984be140714754520c3848b8d9bcf9 (release/2.7)
Author: Arne Schwabe
Date: Mon Aug 10 13:42:06 2026 +0200
Reenable xmit_hold when using p2p tcp-server and tls-server
Signed-off-by: Arne Schwabe <[email protected]>
Acked-by: MaxF <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1837
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg38265.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
