Attention is currently required from: cron2, flichtenheld. stipa has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1526?usp=email )
Change subject: options: Change all users of positive_atoll to uint64_t ...................................................................... Patch Set 9: Code-Review-1 (2 comments) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/1526/comment/8a283739_5f736daf?usp=email : PS9, Line 869: o->renegotiate_seconds_min = 0; > Setting this to 0 is now a noop as it is already set to 0 through the > CLEAR(*o). […] Hm.. we do have following code: if (options->renegotiate_seconds_min < 0) { /* Add 10% jitter to reneg-sec by default (server side only) */ in do_init_crypto_tls(), does it mean that this assignment to zero kills 10% jitter? File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/1526/comment/9f6a9cff_7b428211?usp=email : PS9, Line 110: if (*reneg_bytes == 0) /* Not user-specified */ reneg-bytes 0 means disabling byte-based renegotiation according to man page. After this change "disabled" and "not set" becomes indistinguishable. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1526?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I701452496bb47c58b9728b08104dd5cb7823a94f Gerrit-Change-Number: 1526 Gerrit-PatchSet: 9 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: stipa <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Fri, 14 Aug 2026 09:53:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: plaisthos <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
