Attention is currently required from: flichtenheld, plaisthos.

stipa has posted comments on this change by flichtenheld. ( 
http://gerrit.openvpn.net/c/openvpn/+/1610?usp=email )

Change subject: Remove various unused functions
......................................................................


Patch Set 12: Code-Review-1

(2 comments)

File src/openvpn/buffer.h:

http://gerrit.openvpn.net/c/openvpn/+/1610/comment/f8148efd_ce4f2c31?usp=email :
PS12, Line 818: {
> Yeah, there are some examples in here where we remove parts of an API that 
> are not currently used bu […]
OOB patch series (not merged yet) is the consumer of buf_read_u32. Besides, we 
have write_u16/u32/u64 so removing read_u32 would create an inconsistency.


File src/openvpn/multi_io.c:

http://gerrit.openvpn.net/c/openvpn/+/1610/comment/0703568e_f099715c?usp=email :
PS12, Line 666: multi_io_delete_event(struct multi_io *multi_io, event_t event)
multi_io.h still has a prototype of multi_io_delete_event



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1610?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I82a4e82ff876fab715e052de1903c65b835360b5
Gerrit-Change-Number: 1610
Gerrit-PatchSet: 12
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-Reviewer: stipa <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Fri, 14 Aug 2026 10:05:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos <[email protected]>
Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to