Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1617?usp=email )
Change subject: Remove various useless assignments ...................................................................... Patch Set 12: (1 comment) File src/openvpn/console_builtin.c: http://gerrit.openvpn.net/c/openvpn/+/1617/comment/a42ad3c9_4f641da3?usp=email : PS11, Line 203: msg(M_FATAL, "Sorry, but I can't get console input on this OS (%s)", prompt); > this loses return. […] In general we added EXIT_FATAL macro to msg() exactly so that tools would not complain. We do not usually add return statements after M_FATAL. But of course in most functions there is some return still afterwards. Not sure how we would test this specific instance. I don't know if we even have a platform where this code branch is used... -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1617?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id0caa497c4ff1ad8743cb23f332f003b2d3393ed Gerrit-Change-Number: 1617 Gerrit-PatchSet: 12 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: stipa <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: stipa <[email protected]> Gerrit-Comment-Date: Fri, 14 Aug 2026 10:40:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: stipa <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
