Attention is currently required from: flichtenheld, plaisthos. razvanc has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1772?usp=email )
Change subject: options: Factor out options display code from options.c ...................................................................... Patch Set 2: (4 comments) Patchset: PS2: Left comments on a few minor issues. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/1772/comment/48bb3d28_3d57c2e6?usp=email : PS2, Line 931: static void This function is now preceeded by 2 blank lines. File src/openvpn/options_show.h: http://gerrit.openvpn.net/c/openvpn/+/1772/comment/fda60c25_db68c638?usp=email : PS2, Line 42: #endif Nit: missing `/* OPTIONS_SHOW_H */` File src/openvpn/options_show.c: http://gerrit.openvpn.net/c/openvpn/+/1772/comment/e75de4d9_cbb1939e?usp=email : PS2, Line 25: #endif Don't we want to #include "options_show.h" here, and include config.h in that header? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1772?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I61762374c141662d596bbf88b64ca7f7472b5149 Gerrit-Change-Number: 1772 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: razvanc <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Mon, 17 Aug 2026 11:04:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
