Attention is currently required from: plaisthos.

razvanc has posted comments on this change by plaisthos. ( 
http://gerrit.openvpn.net/c/openvpn/+/1844?usp=email )

Change subject: Reduce number of future epoch keys from 16 to 4
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2:
This now looks good, just a couple of more nits:

1. I think it's GiB not GB.

2. I've grepped for ' 16 ' in the code and we have now-stale references to the 
old value in crypto_epoch.c (lines 311 and 312). Maybe we want to say something 
like ""at most epoch_data_keys_future_count keys" there to avoid future cases 
where this goes out of sync?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1844?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id3c6681b29026c2920a62a0ea570fd098649e197
Gerrit-Change-Number: 1844
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Mon, 17 Aug 2026 13:21:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to