Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1847?usp=email
to review the following change.
Change subject: gen-release-tarballs.sh: Fix some shell issues
......................................................................
gen-release-tarballs.sh: Fix some shell issues
- Force bash, this script uses {gz,xz} style globs which
are a bashism.
- Change a `` with nested "" to $(). The current code
is correct but shfmt would do this conversion wrong,
so do it manually now.
Change-Id: I10b912bad3bb0b97e2b47eae20d2dd7ffb0c6879
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M dev-tools/gen-release-tarballs.sh
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/47/1847/1
diff --git a/dev-tools/gen-release-tarballs.sh
b/dev-tools/gen-release-tarballs.sh
index 6071b57..83bdc9e 100755
--- a/dev-tools/gen-release-tarballs.sh
+++ b/dev-tools/gen-release-tarballs.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# gen-release-tarballs.sh - Generates release tarballs with signatures
#
# Copyright (C) 2017-2026 - David Sommerseth <[email protected]>
@@ -70,7 +70,7 @@
{
local wildcard="$1"
- res="`find . -maxdepth 1 -type f -name \"$wildcard\" | head -n1 | cut -d/
-f2-`"
+ res="$(find . -maxdepth 1 -type f -name "$wildcard" | head -n1 | cut -d/
-f2-)"
if [ $? -ne 0 ]; then
echo "-- 'find' failed."
exit 5
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1847?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I10b912bad3bb0b97e2b47eae20d2dd7ffb0c6879
Gerrit-Change-Number: 1847
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
