Attention is currently required from: plaisthos, razvanc. flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1585?usp=email )
Change subject: dev-tools: Add new script to convert mails to Gerrit patches ...................................................................... Patch Set 2: (3 comments) File dev-tools/gerrit-submit-from-mail.sh: http://gerrit.openvpn.net/c/openvpn/+/1585/comment/1626c89a_aa90ebae?usp=email : PS1, Line 18: TIMESTAMP=$(date +%Y%M%dT%H%S) > This timestamp looks broken. `M` is minutes. I believe you want > `%Y%m%dT%H%M%S`. Done http://gerrit.openvpn.net/c/openvpn/+/1585/comment/b0137a42_40d14fca?usp=email : PS1, Line 22: git -C $SOURCE_DIR am > Should we check if this failed? we run under "-e" so it should fail the script http://gerrit.openvpn.net/c/openvpn/+/1585/comment/6517b809_a55216a4?usp=email : PS1, Line 37: if [ "$warnings" -ge 0 ]; then > Isn't `warning` always `>= 0`? Did you mean `-gt` here? Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1585?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I52773764e0f4056fe5367918a9b2e6720b165c21 Gerrit-Change-Number: 1585 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: razvanc <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: razvanc <[email protected]> Gerrit-Comment-Date: Mon, 24 Aug 2026 15:32:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: razvanc <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
