Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1864?usp=email
to review the following change.
Change subject: route: Remove unused function route_list_vpn_gateway_needed
......................................................................
route: Remove unused function route_list_vpn_gateway_needed
This function has not been used since commit
840799182c0769c8ac9d014d09a497563516fc0d from 2011.
So it is probably safe to assume it is not useful.
Identified by cppcheck.
Change-Id: I7217d87a0f133e0bbee7896984e668cd28db73bd
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/route.h
1 file changed, 0 insertions(+), 13 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/64/1864/1
diff --git a/src/openvpn/route.h b/src/openvpn/route.h
index 88107e9..473df87 100644
--- a/src/openvpn/route.h
+++ b/src/openvpn/route.h
@@ -409,19 +409,6 @@
return mask;
}
-static inline bool
-route_list_vpn_gateway_needed(const struct route_list *rl)
-{
- if (!rl)
- {
- return false;
- }
- else
- {
- return !(rl->spec.flags & RTSA_REMOTE_ENDPOINT);
- }
-}
-
static inline int
route_did_redirect_default_gateway(const struct route_list *rl)
{
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1864?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7217d87a0f133e0bbee7896984e668cd28db73bd
Gerrit-Change-Number: 1864
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
