cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1863?usp=email )
The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: dco_win: Remove unused dco_start_tun declaration ...................................................................... dco_win: Remove unused dco_start_tun declaration This function was removed in commit 1625d927fc79e2926015ded06a01fd8e460a4bc7, but the declaration and the non-Windows definition were left behind. Identified by cppcheck. Change-Id: I395cc722d53201d775c20ae3cf9d50149bfc90ed Signed-off-by: Frank Lichtenheld <[email protected]> Acked-by: Gert Doering <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1863 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg38640.html Signed-off-by: Gert Doering <[email protected]> --- M src/openvpn/dco_win.h 1 file changed, 0 insertions(+), 10 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/63/1863/2 diff --git a/src/openvpn/dco_win.h b/src/openvpn/dco_win.h index ac3ce33..a92e5ad 100644 --- a/src/openvpn/dco_win.h +++ b/src/openvpn/dco_win.h @@ -65,8 +65,6 @@ void dco_p2p_new_peer(HANDLE handle, OVERLAPPED *ov, struct link_socket *sock, struct signal_info *sig_info); -void dco_start_tun(struct tuntap *tt); - bool dco_win_supports_multipeer(void); void dco_win_add_iroute_ipv4(dco_context_t *dco, in_addr_t dst, unsigned int netbits, @@ -79,13 +77,5 @@ void dco_win_del_iroute_ipv6(dco_context_t *dco, struct in6_addr dst, unsigned int netbits); -#else /* if defined(ENABLE_DCO) && defined(_WIN32) */ - -static inline void -dco_start_tun(struct tuntap *tt) -{ - ASSERT(false); -} - #endif /* defined(_WIN32) */ #endif /* ifndef DCO_H */ -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1863?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I395cc722d53201d775c20ae3cf9d50149bfc90ed Gerrit-Change-Number: 1863 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
