cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1865?usp=email )
The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: route: Remove unused function print_routes ...................................................................... route: Remove unused function print_routes This function has never been used in the git history. Probably an OpenVPN 1.x remnant. Identified by cppcheck. Change-Id: Idfa78643da27fe8a8bd0ff2bcf3025d8687024a9 Signed-off-by: Frank Lichtenheld <[email protected]> Acked-by: Gert Doering <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1865 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg38636.html Signed-off-by: Gert Doering <[email protected]> --- M src/openvpn/route.c M src/openvpn/route.h 2 files changed, 0 insertions(+), 36 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/65/1865/2 diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 8ea745d..6dbe3ec 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -185,19 +185,6 @@ dest->gc = a; } -static const char * -route_string(const struct route_ipv4 *r, struct gc_arena *gc) -{ - struct buffer out = alloc_buf_gc(256, gc); - buf_printf(&out, "ROUTE network %s netmask %s gateway %s", print_in_addr_t(r->network, 0, gc), - print_in_addr_t(r->netmask, 0, gc), print_in_addr_t(r->gateway, 0, gc)); - if (r->flags & RT_METRIC_DEFINED) - { - buf_printf(&out, " metric %d", r->metric); - } - return BSTR(&out); -} - static bool is_route_parm_defined(const char *parm) { @@ -1325,27 +1312,6 @@ #endif /* ifndef ENABLE_SMALL */ static void -print_route(const struct route_ipv4 *r, msglvl_t msglevel) -{ - struct gc_arena gc = gc_new(); - if (r->flags & RT_DEFINED) - { - msg(msglevel, "%s", route_string(r, &gc)); - } - gc_free(&gc); -} - -void -print_routes(const struct route_list *rl, msglvl_t msglevel) -{ - struct route_ipv4 *r; - for (r = rl->routes; r; r = r->next) - { - print_route(r, msglevel); - } -} - -static void setenv_route(struct env_set *es, const struct route_ipv4 *r, int i) { struct gc_arena gc = gc_new(); diff --git a/src/openvpn/route.h b/src/openvpn/route.h index 88107e9..bae8659 100644 --- a/src/openvpn/route.h +++ b/src/openvpn/route.h @@ -377,8 +377,6 @@ #endif -void print_routes(const struct route_list *rl, msglvl_t msglevel); - #ifdef _WIN32 void show_routes(msglvl_t msglevel); -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1865?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Idfa78643da27fe8a8bd0ff2bcf3025d8687024a9 Gerrit-Change-Number: 1865 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
