cron2 has submitted this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/1866?usp=email )

Change subject: mroute: Remove unused functions
......................................................................

mroute: Remove unused functions

Both of these have been unused since commit
1308ccec9f85418b088723bb870855c0a933311b
("Remove support for PF").
The first is ipv4 specific and very limited in scope.
The second is equivalent to just using CLEAR (at least
in actual usage).
So I think both can safely be removed.

Identified by cppcheck.

Change-Id: Iad13c3bf73dbe073e52ede504ced7fb2f6a9b71d
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1866
Message-Id: <[email protected]>
URL: 
https://www.mail-archive.com/[email protected]/msg38645.html
Signed-off-by: Gert Doering <[email protected]>
---
M src/openvpn/mroute.h
1 file changed, 0 insertions(+), 20 deletions(-)




diff --git a/src/openvpn/mroute.h b/src/openvpn/mroute.h
index 639281b..9d61b22 100644
--- a/src/openvpn/mroute.h
+++ b/src/openvpn/mroute.h
@@ -249,24 +249,4 @@
     dest->v4.addr = htonl(src);
 }

-static inline in_addr_t
-in_addr_t_from_mroute_addr(const struct mroute_addr *addr)
-{
-    if ((addr->type & MR_ADDR_MASK) == MR_ADDR_IPV4 && addr->netbits == 0 && 
addr->len == 4)
-    {
-        return ntohl(addr->v4.addr);
-    }
-    else
-    {
-        return 0;
-    }
-}
-
-static inline void
-mroute_addr_reset(struct mroute_addr *ma)
-{
-    ma->len = 0;
-    ma->type = MR_ADDR_NONE;
-}
-
 #endif /* MROUTE_H */

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1866?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iad13c3bf73dbe073e52ede504ced7fb2f6a9b71d
Gerrit-Change-Number: 1866
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to