Attention is currently required from: cron2, plaisthos, razvanc. flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1259?usp=email )
Change subject: init: Fix conversion warnings ...................................................................... Patch Set 20: (4 comments) File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/1259/comment/ded92b20_f010bc69?usp=email : PS19, Line 479: const long j = get_random() % (i + 1); > On systems where `int64_t` (which is what `get_random()` really returns) is > larger than `long` (whic […] Done http://gerrit.openvpn.net/c/openvpn/+/1259/comment/0abac177_ddf43818?usp=email : PS19, Line 2868: msg(M_WARN, "TUN MTU value (%zu) must be at least %u", mtu, TUN_MTU_MIN); > Didn't `TUN_MTU_MIN` stay `int`? Done http://gerrit.openvpn.net/c/openvpn/+/1259/comment/53d215a9_4e3811ea?usp=email : PS19, Line 2875: return (unsigned int)mtu; > `frame_finalize_options()` calls `get_frame_mtu()` and puts the return value > in a plain `int` (`fram […] Done http://gerrit.openvpn.net/c/openvpn/+/1259/comment/baaa181d_0575fb2a?usp=email : PS19, Line 2905: payload_size = max_int(payload_size, o->ce.tls_mtu); > Should this be `max_uint()` now? Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1259?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I41b9f7686180f2549bd4984cbbf66059f0ba2b15 Gerrit-Change-Number: 1259 Gerrit-PatchSet: 20 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: razvanc <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Attention: razvanc <[email protected]> Gerrit-Comment-Date: Wed, 26 Aug 2026 11:52:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: razvanc <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
