Attention is currently required from: flichtenheld. plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1852?usp=email )
Change subject: Add unix-script functionality to the --management feature ...................................................................... Patch Set 8: (3 comments) File doc/man-sections/management-options.rst: http://gerrit.openvpn.net/c/openvpn/+/1852/comment/9af954f4_383728c3?usp=email : PS8, Line 33: variables :code:`MANAGEMENT_SOCKET`, :code:`MANAGEMENT_PASSWORD` > The user variable is missing in the list That is because there is none. Our management interface is password only. But the text mentioning a user is incorrect. http://gerrit.openvpn.net/c/openvpn/+/1852/comment/29c5b029_6f84605e?usp=email : PS8, Line 143: :code:`SIGTERM`. > The other documentation and the code says "SIGINT", not "SIGTERM" The code says SIGTERM: if (man->settings.flags & MF_UNIX_SOCK_SCRIPT && !man_password_needed(man)) { msg(D_MANAGEMENT, "MANAGEMENT: Triggering exit on unix-script disconnect"); throw_signal_soft(SIGTERM, "management-exit"); } if (man->settings.flags & MF_CONNECT_AS_CLIENT) { { msg(D_MANAGEMENT, "MANAGEMENT: Triggering management exit"); throw_signal_soft(SIGTERM, "management-exit"); } } I tried to reword the section to make it better understandable. File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/1852/comment/9712adb6_31be8957?usp=email : PS8, Line 4382: c->options.management_addr = platform_create_temp_file( > Are there any "insecure use of temp file" concerns here? If we ignore that > actual file and just use […] You could monitor /tmp and then theoretically create the socket in the right moment to let the client connect to that fake socket. I replaced that code by just using a random socketname. So we don't have to worry about that. But if creating the socket fails, OpenVPN will just exit anyway. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1852?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I307e64079f436aa782f7e24bfff665a545ad2fa0 Gerrit-Change-Number: 1852 Gerrit-PatchSet: 8 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Wed, 26 Aug 2026 16:28:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
