Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1826?usp=email )
Change subject: Make required action returned from pre_decrypt_verdict more explicit ...................................................................... Patch Set 9: Code-Review-1 (3 comments) File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/1826/comment/07cd59a4_a731903c?usp=email : PS4, Line 83: /* Returns true if this packet should create a new session */ > I added the different states as doxygen comments in the enum itself. […] Done File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/1826/comment/9fd8d5e8_9886e72b?usp=email : PS9, Line 99: /** This packet creates a new session normally */ "normally" is not very useful here I think. How about: "This packet creates a new session to store the Wkc while we wait for completion of the challenge." http://gerrit.openvpn.net/c/openvpn/+/1826/comment/3edeef13_ff72c925?usp=email : PS9, Line 102: * the three way handshake */ "This packet creates a new session. The challenge has already been completed." -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1826?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iccdd4cfad090c565aac27e16cdaa9871106c2f89 Gerrit-Change-Number: 1826 Gerrit-PatchSet: 9 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: razvanc <[email protected]> Gerrit-Reviewer: stipa <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: stipa <[email protected]> Gerrit-Comment-Date: Thu, 27 Aug 2026 11:17:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: plaisthos <[email protected]> Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
