Attention is currently required from: plaisthos, srkyn. razvanc has posted comments on this change by srkyn. ( http://gerrit.openvpn.net/c/openvpn/+/1881?usp=email )
Change subject: compat: close all unrelated fds in forked helpers ...................................................................... Patch Set 1: Code-Review-1 (7 comments) Patchset: PS1: This currently doesn't build at all under CMake. File src/compat/close-fds.h: http://gerrit.openvpn.net/c/openvpn/+/1881/comment/b5a8e1be_189d30c5?usp=email : PS1, Line 13: */ The rest of the files have a more comprehensive block of text about the license, we probably want to follow the existing convention. http://gerrit.openvpn.net/c/openvpn/+/1881/comment/e7c13955_06de8eed?usp=email : PS1, Line 19: void close_fds_except(int keep); The new function lost all previous (Doxygen) documentation explaining the need for it and what it does. File src/compat/close-fds.c: http://gerrit.openvpn.net/c/openvpn/+/1881/comment/0e85c547_3db5529f?usp=email : PS1, Line 12: * as published by the Free Software Foundation. Truncated license text compared to existing files here as well. File tests/unit_tests/openvpn/test_close_fds.c: http://gerrit.openvpn.net/c/openvpn/+/1881/comment/a7daec1c_2276922f?usp=email : PS1, Line 12: * as published by the Free Software Foundation. License header doesn't match the rest of the code in length. http://gerrit.openvpn.net/c/openvpn/+/1881/comment/f95dff6f_c2a250a7?usp=email : PS1, Line 36: run_case(int keep_target) The current convention AFAICT is to use cmocka for tests, which this does not. http://gerrit.openvpn.net/c/openvpn/+/1881/comment/114c5b35_7564e0eb?usp=email : PS1, Line 109: : EXIT_FAILURE; Might we also want to test that fds 0, 1 and 2 survive? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1881?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iacd56d245e9ab30cfb25b2b364ca661fa289dc55 Gerrit-Change-Number: 1881 Gerrit-PatchSet: 1 Gerrit-Owner: srkyn <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: razvanc <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: srkyn <[email protected]> Gerrit-Comment-Date: Fri, 28 Aug 2026 07:05:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
