Attention is currently required from: plaisthos, razvanc. flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1912?usp=email )
Change subject: Fix various function parameters shadowing other symbols ...................................................................... Patch Set 3: (3 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/1912/comment/d0be69b2_0437cfdf?usp=email : PS2, Line 14: either renaming the global variables, the function parameters. > Missing "or"? Done http://gerrit.openvpn.net/c/openvpn/+/1912/comment/e8753274_361af211?usp=email : PS2, Line 16: In one case I removed the parameter since it only cointained > Typo: "contained". Done File src/openvpn/manage.c: http://gerrit.openvpn.net/c/openvpn/+/1912/comment/aafa5bd1_3b753e57?usp=email : PS2, Line 3113: man_output_env(es, true, management->connection.env_filter_level, "CLIENT"); > Shouldn't this be man->connection... […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1912?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0ac934da5eeed0424b54ed9b528a2bf2b561ffdf Gerrit-Change-Number: 1912 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: razvanc <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: razvanc <[email protected]> Gerrit-Comment-Date: Fri, 11 Sep 2026 15:09:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: razvanc <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
