Attention is currently required from: cron2, plaisthos. razvanc has posted comments on this change by cron2. ( http://gerrit.openvpn.net/c/openvpn/+/1914?usp=email )
Change subject: options: fix unsigned underflow when clearing domain_search_list ...................................................................... Patch Set 1: (2 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/1914/comment/7bc87ed3_c5700913?usp=email : PS1, Line 18: o->domain_search_list[SIZE_MAX] = NULL This is not true. `domain_search_list_len` is not `size_t`. It is `unsigned int` and wraps to `UINT_MAX`. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/1914/comment/b78d0c03_9dc5cd4e?usp=email : PS1, Line 3784: } If understand this correctly, the following would just remove the loop, and with it this whole class of bug: ``` o->domain_search_list_len = 0; CLEAR(o->domain_search_list); ``` This seems to be prevailing idiom in the rest of the file for similar fields, not sure what made this case special. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1914?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3724236d4acc3d05d786274d6baf34a21c570594 Gerrit-Change-Number: 1914 Gerrit-PatchSet: 1 Gerrit-Owner: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: razvanc <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Comment-Date: Sun, 13 Sep 2026 09:43:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
