I did have some second thoughts about the push_utils.c change, but
Razvan enlightened me ;-) - so this is not changing behaviour, not
a bugfix, and correct code...
Stared at the changes - some of the bits are still ugly, like the code
duplication for the windows version detection, but most of the changes
are correct *and* improve code readability at the same time. Good stuff.
BB agrees that the result is still working ;-) (we had build fails, but
those were - again - something-infrastructure failing random t_client
tests. Restarting made them all succeed)
Your patch has been applied to the master branch.
commit a57e39923d55987336f544ce0c1b3b42c35f0ec0
Author: Frank Lichtenheld
Date: Sat Sep 12 22:07:41 2026 +0200
Remove various useless assignments
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Razvan Cojocaru <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1617
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg39142.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
