signed/unsigned integers, and off-by-ones, C for the win... - thanks for
finding & reporting it, and sending a patch with it.
The patch was updated with feedback from Marco and Razvan.
I have not actively tested this - the integer wraparound is obvious
enough when you look at it, and the new code is is no longer using any
for() loops that might do the wrong thing.
Your patch has been applied to the master and release/2.7 branch.
commit aa12dd64b74142bbbff9f37cec05959ba115c06d (master)
commit d586f8ad9bfc582cc7984fcd482dc7cfacc940e2 (release/2.7)
Author: Cole Munz
Date: Sun Sep 13 15:23:17 2026 +0200
options: fix unsigned underflow when clearing domain_search_list
Signed-off-by: Cole Munz <[email protected]>
Acked-by: Razvan Cojocaru <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1914
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg39157.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel