Attention is currently required from: plaisthos, stipa. ralf_lici has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1751?usp=email )
Change subject: oob: Probe every resolved address of a remote ...................................................................... Patch Set 24: Code-Review-1 (2 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/1751/comment/60a157b9_f39a3941?usp=email : PS24, Line 17: first reply for a remote wins Does this assume that every address of a remote advertises the same priority, weight, and latency margin? If A answers first with priority 100 and B later answers with priority 0, B is ignored and the whole remote is ranked using A's values, even though priority is supposed to take precedence over latency. If this is an intended configuration invariant, it should probably be documented. File src/openvpn/oob.h: http://gerrit.openvpn.net/c/openvpn/+/1751/comment/ff788675_08592794?usp=email : PS24, Line 200: struct timeval sent_at; /* when the first probe went out, for the RTT */ Sharing one timestamp for every address of a remote might be problematic. If A is sent at t=0, B at t=20, and B replies at t=25, B's RTT is recorded as 25ms rather than 5ms. The reply source identifies which destination answered, so the first-send timestamp should be stored per destination. As written, this measures time since probing the remote began, not the RTT of the responding address. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1751?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I00208610e0ce4f3ed9a87233e68ece1b3b8a768a Gerrit-Change-Number: 1751 Gerrit-PatchSet: 24 Gerrit-Owner: stipa <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: ralf_lici <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: stipa <[email protected]> Gerrit-Comment-Date: Wed, 16 Sep 2026 09:33:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
