Attention is currently required from: ralf_lici, stipa. plaisthos has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1752?usp=email )
Change subject: oob: Add --server-probe-reply to advertise probe reply values ...................................................................... Patch Set 28: Code-Review-2 (5 comments) File doc/man-sections/server-options.rst: http://gerrit.openvpn.net/c/openvpn/+/1752/comment/dbc114bf_a9b13251?usp=email : PS24, Line 671: server-probe-reply off Since the goal was to allow eventually the server probe to be a better way of three way handshake allowing a user to turn it off works against this goal. Why do you want to allow it being turned off. Is there a good reason? If yes we should discuss that reason and alternatives. File doc/man-sections/server-options.rst: http://gerrit.openvpn.net/c/openvpn/+/1752/comment/1f9209be_ccb72e66?usp=email : PS28, Line 688: servers of the same priority proportionally to their weights. Should mention if low number or high number of priority means better priority. http://gerrit.openvpn.net/c/openvpn/+/1752/comment/db85ad8a_3cd95c4f?usp=email : PS28, Line 701: gets little what? File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/1752/comment/2e8cbafc_d882789a?usp=email : PS24, Line 259: .priority = (uint16_t)m->top.options.server_probe_reply_priority, If only uint16 is the valid range, then the type should be uint16 and not doing casting here. File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/1752/comment/d8eb059d_c812534d?usp=email : PS28, Line 249: return false; /* --server-probe-reply off: exactly the probe reply, nothing else */ I don't understand what "exactly the probe reply, nothing else" means here. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1752?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id74cfae7e9d69029d2ddbf635ee85a2a6cedc3d8 Gerrit-Change-Number: 1752 Gerrit-PatchSet: 28 Gerrit-Owner: stipa <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: ralf_lici <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: ralf_lici <[email protected]> Gerrit-Attention: stipa <[email protected]> Gerrit-Comment-Date: Thu, 17 Sep 2026 13:24:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
