Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1921?usp=email
to review the following change.
Change subject: GHA: Explicitly set PKG_CONFIG_PATH in Android build
......................................................................
GHA: Explicitly set PKG_CONFIG_PATH in Android build
Otherwise CMake could use the wrong pkg-config file.
It was still using the correct libraries due to
architecture config. However, in Ubuntu 26.04 lz4 has
an additional xxhash dependency and this dependency
was wrongly used.
Change-Id: Icaa76a20ef41e26044fa684d5297f40d8d5ddc8d
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M .github/workflows/build.yaml
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/21/1921/1
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 56dd3ed..d67c215 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -62,6 +62,8 @@
- name: Install dependencies
run: ${VCPKG_ROOT}/vcpkg install openssl lz4 cmocka
- name: configure OpenVPN with cmake
+ env:
+ PKG_CONFIG_PATH: "${{ env.VCPKG_INSTALLED_DIR }}/${{
matrix.vcpkg_triplet }}/lib/pkgconfig"
run: |
cmake -S . -B openvpn-build -DUNSUPPORTED_BUILDS=yes \
-DCMAKE_SYSTEM_NAME=Android -DCMAKE_SYSTEM_VERSION=28 \
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1921?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Icaa76a20ef41e26044fa684d5297f40d8d5ddc8d
Gerrit-Change-Number: 1921
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
