plaisthos has uploaded this change for review. (
http://gerrit.openvpn.net/c/openvpn/+/1943?usp=email )
Change subject: Rename --enable-debug to --enable-developer-debug and turn it
off
......................................................................
Rename --enable-debug to --enable-developer-debug and turn it off
Since the verbose logging is now always enabled
(apart from --enable-small), --enable-debug now only covers true
debug options like gremlin.
Also rename the option to --enable-developer-debug to ensure
existing build script/maintainer do not enable this option
by default.
Change-Id: Ib31928529d10c7722e1f08e9ca7ff596bdebe840
---
M CMakeLists.txt
M Changes.md
M config.h.cmake.in
M configure.ac
4 files changed, 10 insertions(+), 4 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/43/1943/1
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 6eb5954..d553697 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -40,6 +40,7 @@
option(ENABLE_PKCS11 "BUILD with pkcs11-helper" ON)
option(USE_WERROR "Treat compiler warnings as errors (-Werror)" ON)
option(FAKE_ANDROID "Target Android but do not use actual cross
compile/Android cmake to build for simple compile checks on Linux")
+option(ENABLE_DEBUG "Enable building with debug" OFF)
option(ENABLE_DNS_UPDOWN_BY_DEFAULT "Run --dns-updown hook by default" ON)
set(DNS_UPDOWN_PATH "${CMAKE_INSTALL_PREFIX}/libexec/openvpn/dns-updown" CACHE
STRING "Default location for the DNS up/down script")
diff --git a/Changes.md b/Changes.md
index 2684251..7763d59 100644
--- a/Changes.md
+++ b/Changes.md
@@ -23,6 +23,11 @@
the characters mentioned above were already escaped. However, the behavior of
Mbed TLS is slightly different from OpenSSL in that it also escapes "=".
+## Maintainer-visible changes
+
+- The configure-time option `--enable-debug` is no longer
+ available and the verbose logging is now always included.
+
# Overview of changes in 2.7
## New features
diff --git a/config.h.cmake.in b/config.h.cmake.in
index c3bb5a5..c6c0a96 100644
--- a/config.h.cmake.in
+++ b/config.h.cmake.in
@@ -18,8 +18,8 @@
/* Enable shared data channel offload */
#cmakedefine ENABLE_DCO
-/* Enable debugging support (needed for verb>=4) */
-#define ENABLE_DEBUG 1
+/* Enable debugging support */
+#cmakedefine ENABLE_DEBUG
/* Enable internal fragmentation support */
#define ENABLE_FRAGMENT 1
diff --git a/configure.ac b/configure.ac
index 469a475..47e4759 100644
--- a/configure.ac
+++ b/configure.ac
@@ -131,9 +131,9 @@
AC_ARG_ENABLE(
[debug],
- [AS_HELP_STRING([--disable-debug], [disable debugging support (disable
gremlin and verb 7+ messages) @<:@default=yes@:>@])],
+ [AS_HELP_STRING([--enable-developer-debug], [enable developer debugging
support (enable gremlin) @<:@default=yes@:>@])],
,
- [enable_debug="yes"]
+ [enable_debug="no"]
)
AC_ARG_ENABLE(
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1943?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib31928529d10c7722e1f08e9ca7ff596bdebe840
Gerrit-Change-Number: 1943
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
