Attention is currently required from: plaisthos.
razvanc has posted comments on this change by plaisthos. (
http://gerrit.openvpn.net/c/openvpn/+/1944?usp=email )
Change subject: Inline ret definition in dco_linux.c
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
Patchset:
PS1:
cppcheck doesn't understand the `NLA_PUT()` macros, which on failure `goto
nla_put_failure`, which is:
```
nla_put_failure:
nlmsg_free(nl_msg);
return ret;
```
So the -EMSGSIZE initial value _is_ read.
So this patch would add undefined behavior to every path it touches.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1944?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I98f33343d35453219e43b8730cc10bcef119ea20
Gerrit-Change-Number: 1944
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: razvanc <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Wed, 23 Sep 2026 09:31:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
