Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1945?usp=email
to review the following change.
Change subject: proxy: Work-around spurious warning on mingw builds
......................................................................
proxy: Work-around spurious warning on mingw builds
mingw in Ubuntu 26.04 has issues with checking snprintf
format strings against original MS implementation even
though it uses the GCC implementation.
Apply work-around that is good enough for code that is
already gone in master.
Change-Id: If276bd4c5d07fcd26f6749f514f0257eab73249f
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/proxy.c
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/45/1945/1
diff --git a/src/openvpn/proxy.c b/src/openvpn/proxy.c
index 7101d9f..857bf03 100644
--- a/src/openvpn/proxy.c
+++ b/src/openvpn/proxy.c
@@ -767,7 +767,9 @@
char get[80];
CLEAR(buf2);
- snprintf(get, sizeof(get), "%%*s NTLM %%%zus", sizeof(buf2) -
1);
+ /* mingw checks calls to the builtin snprintf() with the
+ * ms_printf archetype, which does not know the 'z' modifier */
+ snprintf(get, sizeof(get), "%%*s NTLM %%%us", (unsigned
int)(sizeof(buf2) - 1));
nparms = sscanf(buf, get, buf2);
/* check for "Proxy-Authenticate: NTLM TlRM..." */
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1945?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: release/2.7
Gerrit-Change-Id: If276bd4c5d07fcd26f6749f514f0257eab73249f
Gerrit-Change-Number: 1945
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
