Attention is currently required from: plaisthos. razvanc has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1950?usp=email )
Change subject: Drop the OpenSSL errors a failed cipher/digest lookup leaves behind ...................................................................... Patch Set 1: (1 comment) File src/openvpn/crypto_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1950/comment/6d2d5b5b_ac6c1bcc?usp=email : PS1, Line 592: crypto_msg(D_LOW, "Cipher algorithm '%s' not found", ciphername); The `cipher_get()` change will now affect how this call behaves, because is was popping queued entries that are now removed before it's called. There may be also be other places where this occurs. If this is acceptable then it's fine, but then it should probably be spelled out in the commit message or code comments. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1950?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I440c4c73865fdbd80f2c607e83c50e345a0e2438 Gerrit-Change-Number: 1950 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: razvanc <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Fri, 25 Sep 2026 10:17:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
