Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1951?usp=email
to review the following change.
Change subject: multi: make multi_add_mbuf static
......................................................................
multi: make multi_add_mbuf static
This function is used only in multi.c and can therefore be
declared as static.
Change-Id: Id999691f74d291f4b902b8ca224a12d9bc7e6046
Signed-off-by: Antonio Quartulli <[email protected]>
---
M src/openvpn/multi.c
M src/openvpn/multi.h
2 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/51/1951/1
diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c
index 3e72b92..c1ceb34 100644
--- a/src/openvpn/multi.c
+++ b/src/openvpn/multi.c
@@ -2833,7 +2833,7 @@
* Add a mbuf buffer to a particular
* instance.
*/
-void
+static void
multi_add_mbuf(struct multi_context *m, struct multi_instance *mi, struct
mbuf_buffer *mb)
{
if (multi_output_queue_ready(m, mi))
diff --git a/src/openvpn/multi.h b/src/openvpn/multi.h
index 6cb86c7..ac6cb78f 100644
--- a/src/openvpn/multi.h
+++ b/src/openvpn/multi.h
@@ -354,8 +354,6 @@
struct multi_instance *multi_get_queue(struct mbuf_set *ms);
-void multi_add_mbuf(struct multi_context *m, struct multi_instance *mi, struct
mbuf_buffer *mb);
-
void multi_ifconfig_pool_persist(struct multi_context *m, bool force);
bool multi_process_signal(struct multi_context *m);
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1951?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id999691f74d291f4b902b8ca224a12d9bc7e6046
Gerrit-Change-Number: 1951
Gerrit-PatchSet: 1
Gerrit-Owner: ordex <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
