Attention is currently required from: ordex, plaisthos, razvanc. ralf_lici has posted comments on this change by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1952?usp=email )
Change subject: dco: stop fetching peer stats during client disconnect ...................................................................... Patch Set 2: (2 comments) File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/1952/comment/948864fb_a0d685bb?usp=email : PS1, Line 507: } > Could removing this here end up with stale stats in some corner case? Would > it be useful to still ca […] Yes this was a real regression. Fixed by calling dco_get_peer_stats_multi in multi_uninit. http://gerrit.openvpn.net/c/openvpn/+/1952/comment/f2b618b0_6d782ed9?usp=email : PS1, Line 506: multi_client_disconnect_setenv(struct multi_context *m, struct multi_instance *mi) > you should remove *m from the param list too. […] wiped it out! -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1952?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic535bb1f0da1739f87e9d6bef6fd1061247b05de Gerrit-Change-Number: 1952 Gerrit-PatchSet: 2 Gerrit-Owner: ralf_lici <[email protected]> Gerrit-Reviewer: ordex <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: razvanc <[email protected]> Gerrit-Attention: ordex <[email protected]> Gerrit-Attention: razvanc <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Fri, 25 Sep 2026 15:16:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ordex <[email protected]> Comment-In-Reply-To: razvanc <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
