This has been sitting in our review queue for a while, because "yeah,
good cleanup, but not really that urgent" - well, GH #1111 came around
the corner, and it seems there are still race conditions that make 
the userland DCO interface hickup (and the server restart, very impolite
behaviour).  Looking closer it seems that we already know (#1067)
that this fix is good, but seem to have forgotten... (sorry)

I have stared-at-code again for a bit (looks good), and subjected this
to the t_server testbed on my Ubuntu DCO test system (succeeded), so
here we go...

I've also added a reference to GH#1111 to the commit message.

Your patch has been applied to the master and release/2.7 branch (bugfix).

commit 08407e0d3c45ab889e6ff4252fc40d778acca149 (master)
commit a85aa33c91c5443a43c2f7ecdd93029b2faf7f5f (release/2.7)
Author: Antonio Quartulli
Date:   Fri Sep 25 15:14:11 2026 +0200

     dco_linux: read multicast notifications on a dedicated netlink socket

     Signed-off-by: Antonio Quartulli <[email protected]>
     Acked-by: Razvan Cojocaru <[email protected]>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1737
     Message-Id: <[email protected]>
     URL: 
https://www.mail-archive.com/[email protected]/msg39497.html
     Signed-off-by: Gert Doering <[email protected]>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to