Thanks. As discussed on IRC, this improves the cases that did work
before (namely, collect stats at server exit) and prepares the ground
to get full counters at client disconnect via the "kernel sends us a
PEER_DEL notification with stats attached" groundwork.
The case "userspace sets out to terminate a peer" (client-kill mgmt
command, for example) did not work before, and very inefficiently so
on a busy server :-o - so we're not losing functionality here, and
can fix this on a cleaner codebase.
I have not tested the actual counter querying behaviour, just stared
at the code change ("so much nice simplification") and ran t_server
tests on it. Razvan deep-dived and +2'ed the change.
Applying to 2.7 had its challenges... the neighbouring code in
multi_uninit() is related to "iterators" which are gone from master...
Your patch has been applied to the master and release/2.7 branch.
commit 459fcbb252b9c9781d2807f4d44dbfd758a26afa (master)
commit da51a901bfd2230161c84007b2ac48df51db4bd1 (release/2.7)
Author: Ralf Lici
Date: Sat Sep 26 22:09:51 2026 +0200
dco: stop fetching peer stats during client disconnect
Signed-off-by: Ralf Lici <[email protected]>
Acked-by: Antonio Quartulli <[email protected]>
Acked-by: Razvan Cojocaru <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1952
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg39533.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
