Attention is currently required from: plaisthos. ralf_lici has posted comments on this change by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1956?usp=email )
Change subject: dco: refresh peer stats before userspace disconnect ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Tested with explicit `client-kill <id> HALT` (HALT is for asking the client to not reconnect immediately): ``` ... MANAGEMENT: CMD 'client-kill 0 HALT' Delayed exit in 5 seconds SENT CONTROL [client]: 'HALT' (status=1) client/udp4:10.10.10.2:42046 rx-peer-id=0 UDPv4 WRITE [65] to [AF_INET]10.10.10.2:42046: P_CONTROL_V1 kid=0 [ 4 3 2 1 ] pid=7 DATA len=27 client/udp4:10.10.10.2:42046 rx-peer-id=0 UDPv4 WRITE [65] to [AF_INET]10.10.10.2:42046: P_CONTROL_V1 kid=0 [ 4 3 2 1 ] pid=7 DATA len=27 register signal: SIGTERM (delayed-exit) client/udp4:10.10.10.2:42046 rx-peer-id=0 SIGTERM[soft,delayed-exit] received, client-instance exiting dco_get_peer: peer-id 0 ovpn-dco: received netlink message type=48 cmd=3 flags=0000 ovpn_handle_peer: parsing message for peer 0... dco_update_peer_stat / dco_read_bytes: 554 dco_update_peer_stat / dco_write_bytes: 410 dco_update_peer_stat / tun_read_bytes: 290 dco_update_peer_stat / tun_write_bytes: 290 register signal: SIGTERM (close_context) dco_del_peer: peer-id 0 dco_read_and_process ovpn-dco: received netlink message type=48 cmd=5 flags=0000 ovpn-dco: received CMD_PEER_DEL_NTF, ifindex: 2, peer-id 0, reason: 1 Received DCO message for unknown peer-id: 0, type 5, del_peer_reason 1 ``` And the negative path (with a peer expiring in the kernel): ``` ... client/udp4:10.10.10.2:51969 rx-peer-id=0 Timers: ping 5, ping-restart 20 client/udp4:10.10.10.2:51969 rx-peer-id=0 Protocol options: protocol-flags cc-exit tls-ekm dyn-tls-crypt dco_read_and_process ovpn-dco: received netlink message type=48 cmd=5 flags=0000 ovpn-dco: received CMD_PEER_DEL_NTF, ifindex: 2, peer-id 0, reason: 2 client/udp4:10.10.10.2:51969 rx-peer-id=0 SIGTERM[soft,ovpn-dco: ping expired] received, client-instance exiting register signal: SIGTERM (close_context) ``` There are no dco_get_peer call during closure, and no redundant dco_del_peer, because dco_peer_id was reset to -1. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1956?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iacbba3dabd8049901212adaf7551abc554b00226 Gerrit-Change-Number: 1956 Gerrit-PatchSet: 1 Gerrit-Owner: ralf_lici <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Mon, 28 Sep 2026 13:39:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
