Thanks for reworking the v6 "tested and approved months ago" on a short
notice - but the new one is really so much nicer, and much better
localized changes ;-)
I'm still not happy with all the details (did_iroutes sits in mi,
while did_dco_iroutes sits in c, and both are "instance specific"
variables... - and also, a function called "schedule_exit()"
maybe shouldn't do more than that - so we should come back and
revisit this eventually)
That said, the problem is well-understood, and the approach to fixing
it (v6, that is) has been tested in production in the Access Server
product. v7 is the same code, just keeping the old function args
to schedule_exit() (because c->net_ctx can be dereferenced from there).
Adding to the experience from there I've run a t_server run on ubuntu+dco
with a bit of iroute activity - not stress testing, just doing basic "does
everything still work?". it does.
Archive reference URL: pointing to lore.kernel.org, because mail-archive.org
refuses to acknowledge v7 of this patch... very opinionated, them.
Your patch has been applied to the master and release/2.7 branch.
commit 2f76d3aac55a5347273013d60eb86aa17c8b8941 (master)
commit e9d8fd2bffeaf28920d1d11b17ccd5c173d3ab18 (release/2.7)
Author: Antonio Quartulli
Date: Mon Sep 28 13:37:18 2026 +0200
dco: remove iroute at client exit time instead of delayed exit
Signed-off-by: Antonio Quartulli <[email protected]>
Acked-by: Razvan Cojocaru <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1683
Message-Id: <[email protected]>
URL:
https://lore.kernel.org/openvpn-devel/[email protected]/T/#u
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
