Attention is currently required from: flichtenheld, plaisthos, ralf_lici.

stipa has posted comments on this change by stipa. ( 
http://gerrit.openvpn.net/c/openvpn/+/1741?usp=email )

Change subject: oob: Add P_CONTROL_OOB_V1 and the probe request and reply TLVs
......................................................................


Patch Set 19:

(2 comments)

Patchset:

PS17:
> We already have TLV parser/write that parses/write TLV with a compatible 
> format for TLV_TYPE_EARLY_N […]
Yeah makes sense. So I moved TLV parser into a separate commit, which also 
replaces TLV parsing in ssl.c.

https://gerrit.openvpn.net/c/openvpn/+/1965

This makes https://gerrit.openvpn.net/c/openvpn/+/1741 much smaller.


Patchset:

PS18:
> This seems to be unfinished. […]
Yes, I changed the wire format only. Let me fix the naming and also look into 
(existing) TLV parser.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1741?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1c8d302ac57c5603d622a7be14be369437388268
Gerrit-Change-Number: 1741
Gerrit-PatchSet: 19
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-Reviewer: ralf_lici <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: ralf_lici <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Wed, 30 Sep 2026 08:28:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to