Attention is currently required from: flichtenheld, plaisthos, ralf_lici, stipa.

razvanc has posted comments on this change by stipa. ( 
http://gerrit.openvpn.net/c/openvpn/+/1744?usp=email )

Change subject: oob: Answer probe requests on the server (P_CONTROL_OOB_V1)
......................................................................


Patch Set 20:

(1 comment)

File src/openvpn/mudp.c:

http://gerrit.openvpn.net/c/openvpn/+/1744/comment/87c486d8_64fb5311?usp=email :
PS20, Line 235:     else if (verdict == VERDICT_VALID_OOB_V1)
Do we want to also gate the following logic on some option being enabled? This 
looks like any valid `P_CONTROL_OOB_V1` will trigger a server response, which 
is basically an unauthenticated reply path.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1744?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I930d3789e0313aa0c3bc51ee5fd1d108343d59f0
Gerrit-Change-Number: 1744
Gerrit-PatchSet: 20
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-Reviewer: ralf_lici <[email protected]>
Gerrit-CC: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: ralf_lici <[email protected]>
Gerrit-Attention: stipa <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Wed, 30 Sep 2026 10:33:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to