From: Arne Schwabe <[email protected]>

Certain handset manufacturers (like Samsung iirc)  are handling
0.0.0.0/0 different from the split /1 routes, so push the 0.0.0.0/0
route to the OS.

Change-Id: I22e4b73e744c765a43bdb29f6e18813d103ea757
Signed-off-by: Arne Schwabe <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/890
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/890
This mail reflects revision 3 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]>

        
diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index e3cd527..cbada6f 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -5615,7 +5615,14 @@
             }
             else if (streq(p[j], "def1"))
             {
+#ifndef TARGET_ANDROID
+                /* The hack that def1 uses to split 0.0.0.0 into 0.0.0.0/1 and
+                 * 128.0.0.0/1 is not needed on Android and will even
+                 * make some Android implementations (e.g. Samsung)
+                 * misbehave, so silently ignore the flag and always use
+                 * 0.0.0.0/0 instead */
                 options->routes->flags |= RG_DEF1;
+#endif
             }
             else if (streq(p[j], "bypass-dhcp"))
             {


_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to