Attention is currently required from: Arne Schwabe, Lev Stipakov. chugly has posted comments on this change by Lev Stipakov. ( https://gerrit.openvpn.net/c/openvpn/+/1704?usp=email )
Change subject: route: Don't delete pre-existing host route to VPN server on disconnect ...................................................................... Patch Set 1: Code-Review+1 Tested on Linux in a network namespace (static-key p2p, --redirect-gateway def1), comparing this change against its parent: - no pre-existing route: the host route to the server is added and removed on exit, same as before - pre-existing host route to the server: the parent deletes it on exit, this change keeps it - pre-existing route to the LAN gateway with block-local (the bypass path): the parent deletes it, this change keeps it I also read through the Windows side, since #970 is a Windows report: add_route_service() and add_route_ipapi() both return RTA_EEXIST on ERROR_OBJECT_ALREADY_EXISTS, so the fix applies with the default route methods. With route.exe an existing route makes the add fail, so it was never marked for deletion in the first place. With --persist-tun the route list survives a restart and routes aren't re-added, so a route we added ourselves isn't mistaken for a pre-existing one on reconnect. -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/1704?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I21d782780b7f89b3061dd97500589a24415afc23 Gerrit-Change-Number: 1704 Gerrit-PatchSet: 1 Gerrit-Owner: Lev Stipakov <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: chugly <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Lev Stipakov <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Comment-Date: Tue, 06 Oct 2026 07:11:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
