Attention is currently required from: Arne Schwabe. Răzvan Cojocaru has posted comments on this change by Arne Schwabe. ( https://gerrit.openvpn.net/c/openvpn/+/1950?usp=email )
Change subject: Do not look up the "none" cipher or digest in OpenSSL ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File src/openvpn/crypto_openssl.c: https://gerrit.openvpn.net/c/openvpn/+/1950/comment/cedba6d5_edec6826?usp=email : PS2, Line 999: } This hunk does not protect anything, and it changes how this function presents failure. It also, if I'm reading it correctly, invalidates the commit message's claim: "has the same shape and would leave the same entry". I also could not find any current callers that can reach it: `md_kt_name()` and `md_kt_size()` check for "none" first, and other callers either pass valid strings here or are guarded by `md_defined()`. Once this hunk is gone (and the commit message amended), I'm happy to give this an ack. -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/1950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I440c4c73865fdbd80f2c607e83c50e345a0e2438 Gerrit-Change-Number: 1950 Gerrit-PatchSet: 2 Gerrit-Owner: Arne Schwabe <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Comment-Date: Mon, 12 Oct 2026 08:04:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
