Attention is currently required from: Lev Stipakov. Steffan Karger has posted comments on this change by Arne Schwabe. ( https://gerrit.openvpn.net/c/openvpn/+/506?usp=email )
Change subject: Implement support for AEAD tag at the end ...................................................................... Patch Set 9: (5 comments) Patchset: PS9: Closing old open comments. File src/openvpn/crypto.c: https://gerrit.openvpn.net/c/openvpn/+/506/comment/456fc94e_df3b137d?usp=email : PS1, Line 426: uint8_t *tag_ptr = NULL; > Not sure if the current static analyzers are smart enough to detect that > these (non-const) variables […] Done https://gerrit.openvpn.net/c/openvpn/+/506/comment/2abddffa_1703a3ee?usp=email : PS1, Line 463: ASSERT(buf_inc_len(&work, outlen)); > Good to add a newline to visually separate the decryption from the > authentication, but the buf_inc_l […] Done File src/openvpn/ssl.h: https://gerrit.openvpn.net/c/openvpn/+/506/comment/36ee5594_435289d1?usp=email : PS1, Line 111: #define IV_PROTO_DATA_V3 (1<<10) > This means that this commit can only go in together with commits for a larger > peer id and larger IV, […] Done File tests/unit_tests/openvpn/test_ssl.c: https://gerrit.openvpn.net/c/openvpn/+/506/comment/9def35a0_b6433278?usp=email : PS4, Line 272: run_data_channel_with_cipher_end(const char *cipher) > s/end/tag_end/ ? (Or even tag_at_end) Done -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/506?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I00821d75342daf3f813b829812d648fe298bea81 Gerrit-Change-Number: 506 Gerrit-PatchSet: 9 Gerrit-Owner: Arne Schwabe <[email protected]> Gerrit-Reviewer: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Lev Stipakov <[email protected]> Gerrit-Reviewer: Steffan Karger <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Lev Stipakov <[email protected]> Gerrit-Comment-Date: Tue, 13 Oct 2026 18:26:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Steffan Karger <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
